Summary list changes #1971
Merged
Summary list changes #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds an option to remove the visually hidden text that is automatically added to links in the component
|
@andysellick The wide title layout changes look good to me, however I am still confused as to why there is a need for both the custom I might be missing something obvious here, it would be good to have a conversation about it when you're around. |
Merged
This was referenced Mar 16, 2021
Merged
This was referenced Mar 17, 2021
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Does the following:
Why
The first change is because I have a situation where the text doesn't work for the default behaviour. The text would be
Change GOV.UK can send you feedback emails- which doesn't make sense. Instead I'd like to be able to pass custom text without the component automatically appending visually hidden text that doesn't make sense.The second change is because again the text I need to put in the component doesn't look great with the current layout.
Visual Changes
No change for the first change, new layout option looks like this.
Trello card: https://trello.com/c/lNkwruEi/647-fix-accessibility-issues-raised-by-dac